__iio_update_buffers() is quite the beast, it does quite a few different
things and has a couple of separate error paths due to this. This series
refactors the function starting with moving the configuration verification
out of the configuration path itself. This means we can verify that the
configuration will be accepted before we make any changes to the device and
don't have to implement rollback functionality. The function is also broken
down into a couple of smaller helper function each which only a single
error path. This should hopefully make it easier to comprehend what is
going on. The last step of the refactoring process is to make sure that we
always leave the device in a sane and consistent state even if we encounter
a fatal error. This allows to potentially recover from the fatal error and
will also make sure that we don't trigger unexpected behavior in drivers.
The main motivation for this series to get __iio_update_buffers() ready for
future extension like the ones that are needed to support DMA buffer
support as well as better support for hardware buffer support.
The last patch in this series is not meant to be applied, but it implements
some simple random error injecting into the various error paths of
__iio_update_buffers(). This was used to test the patch series for
regressions and to make sure that we can indeed recover from fatal errors
now.
- Lars
Lars-Peter Clausen (8):
iio: Replace printk in __iio_update_buffers with dev_dbg
iio: __iio_update_buffers: Slightly refactor scan mask memory
management
iio: __iio_update_buffers: Perform request_update() only for new
buffers
iio: __iio_update_buffers: Update mode before preenable/after
postdisable
iio: __iio_update_buffers: Verify configuration before starting to
apply it
iio: __iio_update_buffers: Split enable and disable path into helper
functions
iio: __iio_update_buffers: Leave device in sane state on error
DO NOT APPLY! __iio_update_buffers error path testing
drivers/iio/industrialio-buffer.c | 364 ++++++++++++++++++++++++--------------
1 file changed, 229 insertions(+), 135 deletions(-)
--
1.8.0
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
