On 03/02/2015 11:39 AM, Roberta Dobrescu wrote:
The return value of gpiod_to_irq should be checked before giving it to devm_request_threaded_irq in order to not pass an error code in case it fails. Signed-off-by: Roberta Dobrescu <roberta.dobrescu@xxxxxxxxx> Reviewed-by: Vlad Dogaru <vlad.dogaru@xxxxxxxxx> --- gpiod_to_irq also appears in the following drivers: * drivers/iio/accel/bmc150-accel.c * drivers/iio/accel/kxcjk-1013.c * drivers/iio/accel/mma9553.c * drivers/iio/gyro/bmg160.c * drivers/iio/imu/kmx61.c * drivers/iio/proximity/sx9500.c, something like this: <code> ret = gpiod_to_irq(gpio); dev_dbg(dev, "GPIO resource, no:%d irq:%d\n", desc_to_gpio(gpio), ret); return ret; </code>
Only slightly related, but why are these drivers even using GPIOs to get the IRQs. As far as I can see the GPIOs are not used otherwise in which case they should rather request the IRQ directly than going making the detour via the GPIO.
- Lars -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
