On February 25, 2015 12:11, Jonathan Cameron wrote: > > +static int da9150_charger_remove(struct platform_device *pdev) > > +{ > > + struct da9150_charger *charger = platform_get_drvdata(pdev); > > + int irq; > > + > > + /* Make sure IRQs are released before unregistering power supplies */ > > + irq = platform_get_irq_byname(pdev, "CHG_VBUS"); > > + free_irq(irq, charger); > I'd use your unregister_irq function here as well. Better than open > coding the same thing again. (more obviously correct as well as the > error condition unwinding above then looks just like we have here). Fair point. Will update that when I start on the additional modules I need to submit. Thanks. ��.n��������+%������w��{.n�����{��(��)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥