Re: [PATCH] iio: improve usage of gpiod API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 18, 2015 at 9:25 AM, Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> Hello Alexandre,
>
> On Wed, Feb 18, 2015 at 04:22:06PM +0900, Alexandre Courbot wrote:
>> On 02/18/2015 04:15 PM, Uwe Kleine-König wrote:
>> >On Wed, Feb 18, 2015 at 10:08:42AM +0900, Alexandre Courbot wrote:
>> >>On 02/17/2015 06:21 PM, Uwe Kleine-König wrote:
>> >>>Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
>> >>>which appeared in v3.17-rc1, the gpiod_get* functions take an additional
>> >>>parameter that allows to specify direction and initial value for
>> >>>outputs.
>> >>>
>> >>>Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>> >>
>> >>Nice, thanks for taking the time to do this!
>> >I have some more, just didn't come around to wrap in commits and send
>> >out:
>> >
>> >     http://git.pengutronix.de/?p=ukl/linux.git;a=commitdiff;h=1783b17ba922f92d043bad650c0209de1c201080;hp=e36f014edff70fc02b3d3d79cead1d58f289332e
>> >
>> >I will do one patch a day ...
>>
>> That's great - do these cover all the uses of gpiod_get* that need
>> to be updated? If so, you could close this series with a final patch
>> that removes the macro definitions allowing variable arguments.
> That's
> http://git.pengutronix.de/?p=ukl/linux.git;a=commitdiff;h=bc10c10785a883133762280f9878d89f2e14ffc6;hp=474ad70e111489255eb622947d3a0a949680ed55


Hi Uwe,

Please make sure you also fix this:

$ ack-grep devm_gpiod_get_index
imu/kmx61.c
1270: gpio = devm_gpiod_get_index(dev, KMX61_GPIO_NAME, 0);

accel/mma9551.c
421: gpio = devm_gpiod_get_index(dev, MMA9551_GPIO_NAME, i);

proximity/sx9500.c
621: gpio = devm_gpiod_get_index(dev, SX9500_GPIO_NAME, 0);

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux