RE: [PATCH] iio: mma9551: fix sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: linux-iio-owner@xxxxxxxxxxxxxxx [mailto:linux-iio-owner@xxxxxxxxxxxxxxx] On Behalf Of Vlad Dogaru
> Sent: 15 December, 2014 17:17
> To: linux-iio@xxxxxxxxxxxxxxx
> Cc: Dogaru, Vlad
> Subject: [PATCH] iio: mma9551: fix sparse warning
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/iio/accel/mma9551.c:554:57: sparse: mixing different enum types
>    drivers/iio/accel/mma9551.c:554:57:     int enum mma9551_tilt_axis  versus
>    drivers/iio/accel/mma9551.c:554:57:     int enum mma9551_gpio_pin
> >> drivers/iio/accel/mma9551.c:576:57: sparse: mixing different enum types
>    drivers/iio/accel/mma9551.c:576:57:     int enum mma9551_tilt_axis  versus
>    drivers/iio/accel/mma9551.c:576:57:     int enum mma9551_gpio_pin
> 
> Signed-off-by: Vlad Dogaru <vlad.dogaru@xxxxxxxxx>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> ---

Reviewed-by: Irina Tirdea <irina.tirdea@xxxxxxxxx>

>  drivers/iio/accel/mma9551.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c
> index 1be125b..6563e26 100644
> --- a/drivers/iio/accel/mma9551.c
> +++ b/drivers/iio/accel/mma9551.c
> @@ -551,7 +551,8 @@ static int mma9551_config_incli_event(struct iio_dev *indio_dev,
>  		return 0;
> 
>  	if (state == 0) {
> -		ret = mma9551_gpio_config(data->client, mma_axis,
> +		ret = mma9551_gpio_config(data->client,
> +					  (enum mma9551_gpio_pin)mma_axis,
>  					  MMA9551_APPID_NONE, 0, 0);
>  		if (ret < 0)
>  			return ret;
> @@ -573,7 +574,8 @@ static int mma9551_config_incli_event(struct iio_dev *indio_dev,
>  			return -EINVAL;
>  		}
> 
> -		ret = mma9551_gpio_config(data->client, mma_axis,
> +		ret = mma9551_gpio_config(data->client,
> +					  (enum mma9551_gpio_pin)mma_axis,
>  					  MMA9551_APPID_TILT, bitnum, 0);
>  		if (ret < 0)
>  			return ret;
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux