On 04/12/14 22:56, Daniel Baluta wrote:
> Minor comment inline.
>
> On Wed, Nov 26, 2014 at 7:55 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>> In preparation for moving the buffer registration to the core make sure to
>> register the same channel array for the device and the buffer. Currently
>> the temperature channel is not registered for the buffer, setting its scan
>> index to -1 will make sure that it is skipped for the buffer.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
>> ---
>> drivers/staging/iio/accel/sca3000_core.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
>> index cd46a61..9eedb93 100644
>> --- a/drivers/staging/iio/accel/sca3000_core.c
>> +++ b/drivers/staging/iio/accel/sca3000_core.c
>> @@ -459,6 +459,7 @@ static const struct iio_chan_spec sca3000_channels_with_temp[] = {
>> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
>> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) |
>> BIT(IIO_CHAN_INFO_OFFSET),
>> + .scan_index = -1,
>
> Would be nice to have /* No buffer support */ comment as in 5/11 patch.
Agreed - have added whilst applying the patch.
>
> Otherwise, it looks good to me.
>
> Daniel.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
