On 04/12/14 22:51, Daniel Baluta wrote: > On Wed, Nov 26, 2014 at 7:55 PM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: >> The convention for IIO devices is that all channels are disabled by default. To be fair - it wasn't the convention when these were written ;) >> >> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > > Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxxxx> Applied to the togreg branch of iio.git. It's just much easier to ensure their are no bugs and everything is predictable. This way we don't end up with people relying on a particular set of channels being enabled. > >> --- >> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c >> index b6bd609..aa6a368 100644 >> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c >> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c >> @@ -757,10 +757,6 @@ static int ad5933_probe(struct i2c_client *client, >> if (ret) >> goto error_unreg_ring; >> >> - /* enable both REAL and IMAG channels by default */ >> - iio_scan_mask_set(indio_dev, indio_dev->buffer, 0); >> - iio_scan_mask_set(indio_dev, indio_dev->buffer, 1); >> - >> ret = ad5933_setup(st); >> if (ret) >> goto error_uninitialize_ring; >> -- >> 1.8.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
