On Fri, 2014-12-05 at 08:03 +0100, Wolfram Sang wrote: > On Thu, Dec 04, 2014 at 03:10:25PM -0800, Srinivas Pandruvada wrote: > > This chip allows some limited number of sensors connected to it as > > slaves, which can be directly accessed by register interface of this > > driver.But the current upstream driver doesn't support such mode. > > To attach such slaves to main processor i2c bus, chip has to be set > > up in bypass mode. This change adds i2c mux, which will enable/disable > > this mode for transaction to/from such slave devices. > > This was discussed for a while in mailing list, this was the outcome: > > Reference: > > http://www.spinics.net/lists/linux-iio/msg12126.html > > http://comments.gmane.org/gmane.linux.kernel.iio/11470 > > > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > > Only minor nits, in general: > > Reviewed-by: Wolfram Sang <wsa@xxxxxxxxxxxxx> > > > +static int inv_mpu6050_create_mux(struct iio_dev *indio_dev) > > +{ > > + struct inv_mpu6050_state *st = iio_priv(indio_dev); > > + struct i2c_client *client = st->client; > > + > > + st->mux_adapter = i2c_add_mux_adapter(client->adapter, > > + &client->dev, > > + indio_dev, > > + 0, 0, 0, > > + inv_mpu6050_select_bypass, > > + inv_mpu6050_deselect_bypass); > > + if (st->mux_adapter == NULL) { > > + dev_err(&st->client->dev, "Mux create Failed\n"); > > i2c_add_mux_adapter prints error messages on its own, so this is not > needed. > > > + return -ENODEV; > > + } > > + > > + return 0; > > +} > > + > > +static void inv_mpu6050_destroy_mux(struct iio_dev *indio_dev) > > +{ > > + struct inv_mpu6050_state *mpu_st = iio_priv(indio_dev); > > + > > + if (mpu_st->mux_adapter) > > + i2c_del_mux_adapter(mpu_st->mux_adapter); > > +} > > Since those two functions are only called once and don't encapsulate > much, I'd rather put the commands directly into the calling functions. Agree. I will move them to the caller and submit another version. I hope, I can still use reviewed-by tag, after this change. Thanks, Srinivas > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
