Hi everyone,
Thanks for the review. I've fixed most of the comments except for the
invalid sample representation issue.
On 10/31/2014 02:19 PM, Lars-Peter Clausen wrote:
> On 10/29/2014 09:45 PM, Ezequiel Garcia wrote:
>> From: Phani Movva <Phani.Movva@xxxxxxxxxx>
>>
>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device.
>>
>> Signed-off-by: Phani Movva <Phani.Movva@xxxxxxxxxx>
>> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx>
>> [Ezequiel: code style cleaning]
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx>
>
> Looks very good. Just a few very minor issues.
>
> [...]
>> +static int cc_adc_poll_done(struct iio_dev *dev, int channel,
>> + unsigned int delay)
>> +{
>> + struct cc_10001_adc_device *adc_dev = iio_priv(dev);
>> + int val = INVALID_SAMPLED_OUTPUT;
>
> I'm not so sure that returning a fake sample is such a good idea. When
> reading from sysfs we should definitely return an error if there is one.
Right.
> For buffer reading dropping the sample is probably not such a good idea,
> but we should agree on and document a standard representation of invalid
> samples.
>
Hm, sure. What do you suggest? I can't see other drivers doing anything
like this.
--
Ezequiel
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
