Re: [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/31/2014 06:19 PM, Lars-Peter Clausen wrote:
On 10/29/2014 09:45 PM, Ezequiel Garcia wrote:
From: Phani Movva <Phani.Movva@xxxxxxxxxx>

This commit adds support for Cosmic Circuits 10001 10-bit ADC device.

Signed-off-by: Phani Movva <Phani.Movva@xxxxxxxxxx>
Signed-off-by: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx>
[Ezequiel: code style cleaning]
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@xxxxxxxxxx>

Looks very good. Just a few very minor issues.

One thing I forgot to mention. We use indio_dev for the name of the struct iio_dev variable. Please use this in this driver as well, makes it easier to follow and review the code.

- Lars

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux