On July 28, 2014 2:37:24 PM GMT+01:00, Martin Fuzzey <mfuzzey@xxxxxxxxxxx> wrote:
>Hi Peter and thank you for the review.
>
>On 23/07/14 20:12, Peter Meerwald wrote:
>> +#define MMA8452_TRANSIENT_CFG_CHAN_MASK(chan) (BIT(1) << chan)
>> could use GENMASK() macro
>
>That would be
>
>#define MMA8452_TRANSIENT_CFG_CHAN_MASK(chan) (GENMASK(chan + 1, chan +
>1))
>
>I don't really see that being better in the single bit case here.
>
>> +
>> +static irqreturn_t mma8452_interrupt(int irq, void *p)
>> +{
>> + struct iio_dev *indio_dev = p;
>> + struct mma8452_data *data = iio_priv(indio_dev);
>> + int ret = IRQ_NONE;
>> + int src;
>> save either ret or src
>Ok, done for V2
>>> +
>>> + src = i2c_smbus_read_byte_data(data->client, MMA8452_INT_SRC);
>>> + if (src < 0)
>>> + goto out;
>> return directly with IRQ_NONE
>Ok, done for V2
>>> +
>>> + if (src & MMA8452_INT_TRANS) {
>>> + mma8452_transient_interrupt(indio_dev);
>>> + ret = IRQ_HANDLED;
>> return directly with IRQ_HANDLED
>Ok, done for V2
>>> + }
>>> +
>>> +out:
>> no need for goto/label
>Ok, done for V2
>> + /* By default set transient threshold to max to avoid events if
>> + * enabling without configuring threshold */
>> not a proper multiline comment
>Ok, fixed for V2
>>> + ret = i2c_smbus_write_byte_data(client, MMA8452_TRANSIENT_THS,
>0x7f);
>>> + if (ret < 0)
>>> + return ret;
>>> +
>>> + if (client->irq) {
>> I am always confused if 0 is a valid irq or not; I think it is, so
>> client->irq >= 0
>
>On my DT platform when I remove the interrupt definition from the
>device
>tree
>I get 0 for client->irq so I think it is not.
Used to be on Arm. A lot of effort went into clearing that up a while back.
J
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
