On 07/23/2014 07:30 PM, Dan Carpenter wrote: > On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote: >> >> >> On 07/17/2014 05:19 PM, Chen Gang wrote: >>> >>> >>> On 07/17/2014 05:16 PM, Dan Carpenter wrote: >>>> On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote: >>>>>>> + return (__force void __iomem *)ERR_PTR(-ENXIO); >>>>>> >>>>>> There's apparently an IOMEM_ERR_PTR() for this nowadays... >>>>>> >>>>> >>>>> IOMEM_ERR_PTR() is defined within "lib/devres.c", not in "./include". >>>>> But may we move it from "lib/devres.c" to "./include/linux/err.h"? >>>>> >>>>> For me, I am not quite sure, it may need additional discussion, but at >>>>> least, that will be another patch. >>>> >>>> Yes. Move it there. That is the right place. >>>> >> >> Sorry for replying late about IOMEM_ERR_PTR(). >> >> Although no objections within 2 days, for me, when move something to >> generic header file, it is not only for future using, but also for >> solving current issue, or it has to be suspended for waiting 'trigger'. >> >> So for me, the patch about IOMEM_ERR_PTR() need be suspended, until some >> member find an issue which may be related with IOMEM_ERR_PTR(), more or >> less. > > Matthias Brugger already moved it to include/linux/io.h on Friday. > OK, thank you for your work. And for me, this 'long discussion' can be finished now (keeping current status no touch). But if any members have additional suggestions and ideas, still welcome to reply directly. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
