On Sat, Jun 28, 2014 at 05:10:46AM +0200, Guillaume Morin wrote: > On 27 Jun 22:37, Greg Kroah-Hartman wrote: > > Put that below the --- line. > > Will do. > > > > > And what checkpatch error did you fix? And are you sure it needs to be > > > > fixed? > > > > > > That's what I changed: > > > > > > $ scripts/checkpatch.pl -f drivers/staging/iio/frequency/ad9850.c > > > ERROR: Macros with complex values should be enclosed in parenthesis > > > > Then why didn't you say that :) > > Well it was not totally clear to me if that was obvious or not. Anyway, > I'll mention it in the future. > > > > > > I assumed that if it was reported as an error, it needed to be fixed... > > > > Use your judgement, checkpatch is a tool, it isn't always correct. > > Right, I guess it's borderline. Should I resend the patch or just drop > it? These days we have GENMASK. http://lxr.free-electrons.com/source/include/linux/bitops.h#L21 Maybe the macro can be used directly instead of the value_mask. > > Guillaume. > > -- > Guillaume Morin <guillaume@xxxxxxxxxxx> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
