Re: [PATCH 2/5] iio: light: cm32181: Use devm_* APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/06/14 09:20, Sachin Kamat wrote:
Hi Beomho,

On Wed, Jun 18, 2014 at 11:51 AM, Beomho Seo <beomho.seo@xxxxxxxxxxx> wrote:
This patch changes API from iio_device_register() to devm_* API.
Using API make code simpler.

Signed-off-by: Beomho Seo <beomho.seo@xxxxxxxxxxx>
Hmm. Fair enough I suppose.

Applied to the togreg branch of iio.git

Jonathan
---
  drivers/iio/light/cm32181.c |   11 +----------
  1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
index d976e6c..ad36b29 100644
--- a/drivers/iio/light/cm32181.c
+++ b/drivers/iio/light/cm32181.c
@@ -331,7 +331,7 @@ static int cm32181_probe(struct i2c_client *client,
                 return ret;
         }

-       ret = iio_device_register(indio_dev);
+       ret = devm_iio_device_register(&client->dev, indio_dev);
         if (ret) {
                 dev_err(&client->dev,
                         "%s: regist device failed\n",
@@ -342,14 +342,6 @@ static int cm32181_probe(struct i2c_client *client,
         return 0;
  }

-static int cm32181_remove(struct i2c_client *client)
-{
-       struct iio_dev *indio_dev = i2c_get_clientdata(client);
-
-       iio_device_unregister(indio_dev);
-       return 0;
-}
-
  static const struct i2c_device_id cm32181_id[] = {
         { "cm32181", 0 },
         { }
@@ -370,7 +362,6 @@ static struct i2c_driver cm32181_driver = {
         },
         .id_table       = cm32181_id,
         .probe          = cm32181_probe,
-       .remove         = cm32181_remove,
  };

  module_i2c_driver(cm32181_driver);
--
1.7.9.5


Looks good.
Reviewed-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux