Re: [PATCH v2 02/12] iio:adc:ad5504: Use BIT() and GENMASK() macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/06/14 06:00, Peter Meerwald wrote:
Signed-off-by: Peter Meerwald <pmeerw@xxxxxxxxxx>
Acked-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
I would have ever so slightly preferred the kernel doc fix
to be in another patch, but ah well.

Applied to the togreg branch of iio.git

Thanks,
---
  drivers/iio/dac/ad5504.c | 11 +++++------
  1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index 1e64493..c917dd2 100644
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -15,17 +15,16 @@
  #include <linux/sysfs.h>
  #include <linux/regulator/consumer.h>
  #include <linux/module.h>
+#include <linux/bitops.h>

  #include <linux/iio/iio.h>
  #include <linux/iio/sysfs.h>
  #include <linux/iio/events.h>
  #include <linux/iio/dac/ad5504.h>

-#define AD5505_BITS			12
-#define AD5504_RES_MASK			((1 << (AD5505_BITS)) - 1)
-
-#define AD5504_CMD_READ			(1 << 15)
-#define AD5504_CMD_WRITE		(0 << 15)
+#define AD5504_RES_MASK			GENMASK(11, 0)
+#define AD5504_CMD_READ			BIT(15)
+#define AD5504_CMD_WRITE		0
  #define AD5504_ADDR(addr)		((addr) << 12)

  /* Registers */
@@ -42,7 +41,7 @@

  /**
   * struct ad5446_state - driver instance specific data
- * @us:			spi_device
+ * @spi:			spi_device
   * @reg:		supply regulator
   * @vref_mv:		actual reference voltage used
   * @pwr_down_mask	power down mask


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux