On 02/06/14 20:17, Paul Kocialkowski wrote:
Le lundi 02 juin 2014 à 20:10 +0200, Sebastian Reichel a écrit :
Hi,
On Mon, Jun 02, 2014 at 07:00:06PM +0100, Jonathan Cameron wrote:
On 24/05/14 13:09, Paul Kocialkowski wrote:
Not setting the raw parameter in the request causes it to be randomly
initialized to a value that might be different from zero or zero. This leads to
values that are randomly either raw or processed, making it very difficult to
make reliable use of the values.
Signed-off-by: Paul Kocialkowski <contact@xxxxxxxx>
This one seems obvious enough to me that I've applied it to the fixes-togreg
branch. Note you should cc the author or if the log makes it clear someone
else has been working with the driver recently, then cc them.
In this case Sebastian.
Thanks for your feedback and sorry that I didn't check the previous
contributors to the driver!
The commit message looks a bit odd "[...] different from zero or
zero".
How about replacing that with: "that may or may not be zero" and
inversing "processed" and "raw" in the next sentence (if that's not too
late)? The commit message would be:
Not setting the raw parameter in the request causes it to be randomly
initialized to a value that may or may not be zero. This leads to
values that are randomly either processed or raw, making it very
difficult to make reliable use of the values.
Whilst original text was a little unwieldy it was clear enough so I've left
it bit.
In case this is still relevant:
Acked-By: Sebastian Reichel <sre@xxxxxxxxxx>
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
