Jonathan, On Wed, Apr 23, 2014 at 1:54 PM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On 22/04/14 01:03, Doug Anderson wrote: >> >> The whole IIO subsystem can be moved to a module. If you make it a >> module then stuff marked as "Y" in the adc directory simply won't be >> linked in properly. >> >> The two configs that were wrong were EXYNOS_ADC and LP8788_ADC. I >> know for a fact that EXYNOS_ADC will work as a module (though it >> appears to crash when you unload it--that needs to be addressed >> separately). > > I'd really like to see this pinned down before taking this patch. > I can see you argument that the current approach is clearly wrong, > but swapping one issue for another is not an approach I'd particularly > like to take... > > I can't immediately spot the cause of the crash, but there are certainly > some interesting order issues in this driver. Not enabling the vdd > regulator until after the userspace interfaces are exposed (by the > iio_device_register call) is interesting for a start. > > The remove doesn't run in the reverse of the probe order (see clocks > vs regulators for example.) > > Gah, my reviewing for one clearly missed some things in this driver. OK, fair enough. I took a quick look and couldn't spot anything either. I've requested that Samsung dig into these problems. If they are unable to I will take a crack at it as time permits. ;) Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
