On 10/29/13 11:39, Sachin Kamat wrote:
> devm_iio_device_register simplifies the code.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
This highlights the issue I raised before. The driver really ought to be
shuting down the device. Thus there should be some code in the unregister
that is not there.
Hence, nope on this one.
> ---
> drivers/iio/accel/kxsd9.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/iio/accel/kxsd9.c b/drivers/iio/accel/kxsd9.c
> index d72118d..877ae67 100644
> --- a/drivers/iio/accel/kxsd9.c
> +++ b/drivers/iio/accel/kxsd9.c
> @@ -243,14 +243,7 @@ static int kxsd9_probe(struct spi_device *spi)
> spi_setup(spi);
> kxsd9_power_up(st);
>
> - return iio_device_register(indio_dev);
> -}
> -
> -static int kxsd9_remove(struct spi_device *spi)
> -{
> - iio_device_unregister(spi_get_drvdata(spi));
> -
> - return 0;
> + return devm_iio_device_register(&spi->dev, indio_dev);
> }
>
> static const struct spi_device_id kxsd9_id[] = {
> @@ -265,7 +258,6 @@ static struct spi_driver kxsd9_driver = {
> .owner = THIS_MODULE,
> },
> .probe = kxsd9_probe,
> - .remove = kxsd9_remove,
> .id_table = kxsd9_id,
> };
> module_spi_driver(kxsd9_driver);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
