On 10/24/13 12:53, Sachin Kamat wrote:
> The if check is redundant as the value obtained from
> iio_device_register() is already in the required format.
> Hence return the function directly. Error messages are already
> printed by iio_device_register(); hence not needed.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
Technically changing a dmesg output is userspace abi, but I doubt anyone
actually cares so dropping it is fine (anyone who does should shout and we'll
put it back!)
Hence Applied to the togreg branch of iio.git
> ---
> drivers/iio/dac/ad5421.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5421.c b/drivers/iio/dac/ad5421.c
> index c44afeb..3eeaa82 100644
> --- a/drivers/iio/dac/ad5421.c
> +++ b/drivers/iio/dac/ad5421.c
> @@ -514,13 +514,7 @@ static int ad5421_probe(struct spi_device *spi)
> return ret;
> }
>
> - ret = iio_device_register(indio_dev);
> - if (ret) {
> - dev_err(&spi->dev, "Failed to register iio device: %d\n", ret);
> - return ret;
> - }
> -
> - return 0;
> + return iio_device_register(indio_dev);
> }
>
> static int ad5421_remove(struct spi_device *spi)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
