On 10/12/2013 08:46 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Add the missing clk_disable_unprepare() before return
> from adf4350_probe() in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
Reviewed-by: Lars-Peter CLausen <lars@xxxxxxxxxx>
Thanks.
> ---
> drivers/iio/frequency/adf4350.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf4350.c
> index a7b30be..52605c0 100644
> --- a/drivers/iio/frequency/adf4350.c
> +++ b/drivers/iio/frequency/adf4350.c
> @@ -525,8 +525,10 @@ static int adf4350_probe(struct spi_device *spi)
> }
>
> indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> - if (indio_dev == NULL)
> - return -ENOMEM;
> + if (indio_dev == NULL) {
> + ret = -ENOMEM;
Here is a extra space. Jonathan can you clean this up when applying the
patch? Thanks.
> + goto error_disable_clk;
> + }
>
> st = iio_priv(indio_dev);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
