Re: [PATCH 23/25] staging:iio:ad7746: Report scale as fractional value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/28/13 10:31, Lars-Peter Clausen wrote:
> Move the complexity of calculating the fixed point scale to the core.
> 
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Should probably mention the tidying up in the commit message, but it is
trivial so I won't bother changing it ;)

Applied to the togreg branch of iio.git

Thanks
> ---
>  drivers/staging/iio/cdc/ad7746.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
> index 75a533b..862d68d 100644
> --- a/drivers/staging/iio/cdc/ad7746.c
> +++ b/drivers/staging/iio/cdc/ad7746.c
> @@ -656,20 +656,21 @@ static int ad7746_read_raw(struct iio_dev *indio_dev,
>  		switch (chan->type) {
>  		case IIO_CAPACITANCE:
>  			/* 8.192pf / 2^24 */
> -			*val2 = 488;
>  			*val =  0;
> +			*val2 = 488;
> +			ret = IIO_VAL_INT_PLUS_NANO;
>  			break;
>  		case IIO_VOLTAGE:
>  			/* 1170mV / 2^23 */
> -			*val2 = 139475;
> -			*val =  0;
> +			*val = 1170;
> +			*val2 = 23;
> +			ret = IIO_VAL_FRACTIONAL_LOG2;
>  			break;
>  		default:
> -			ret =  -EINVAL;
> -			goto out;
> +			ret = -EINVAL;
> +			break;
>  		}
>  
> -		ret = IIO_VAL_INT_PLUS_NANO;
>  		break;
>  	default:
>  		ret = -EINVAL;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux