Re: [PATCH 19/25] staging:iio:ad7280a: Report scale as fractional value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/28/13 10:31, Lars-Peter Clausen wrote:
> Move the complexity of calculating the fixed point scale to the core.
> 
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Applied
> ---
>  drivers/staging/iio/adc/ad7280a.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index e7191e4..8209fa5 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -783,7 +783,6 @@ static int ad7280_read_raw(struct iio_dev *indio_dev,
>  			   long m)
>  {
>  	struct ad7280_state *st = iio_priv(indio_dev);
> -	unsigned int scale_uv;
>  	int ret;
>  
>  	switch (m) {
> @@ -804,13 +803,12 @@ static int ad7280_read_raw(struct iio_dev *indio_dev,
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_SCALE:
>  		if ((chan->address & 0xFF) <= AD7280A_CELL_VOLTAGE_6)
> -			scale_uv = (4000 * 1000) >> AD7280A_BITS;
> +			*val = 4000;
>  		else
> -			scale_uv = (5000 * 1000) >> AD7280A_BITS;
> +			*val = 5000;
>  
> -		*val =  scale_uv / 1000;
> -		*val2 = (scale_uv % 1000) * 1000;
> -		return IIO_VAL_INT_PLUS_MICRO;
> +		*val2 = AD7280A_BITS;
> +		return IIO_VAL_FRACTIONAL_LOG2;
>  	}
>  	return -EINVAL;
>  }
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux