Re: [PATCH 11/25] iio:ad5791: Report scale as fractional value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/28/13 10:31, Lars-Peter Clausen wrote:
> Move the complexity of calculating the fixed point scale to the core.
> 
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
The minus 1 in here had me confused for a bit, but that is indeed
the transfer function given in the datasheet.

Applied to the togreg branch of iio.git

Thanks,
> ---
>  drivers/iio/dac/ad5791.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5791.c b/drivers/iio/dac/ad5791.c
> index 3cee89b..d64acbd 100644
> --- a/drivers/iio/dac/ad5791.c
> +++ b/drivers/iio/dac/ad5791.c
> @@ -270,9 +270,9 @@ static int ad5791_read_raw(struct iio_dev *indio_dev,
>  		*val >>= chan->scan_type.shift;
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_SCALE:
> -		*val = 0;
> -		*val2 = (((u64)st->vref_mv) * 1000000ULL) >> chan->scan_type.realbits;
> -		return IIO_VAL_INT_PLUS_MICRO;
> +		*val = st->vref_mv;
> +		*val2 = (1 << chan->scan_type.realbits) - 1;
> +		return IIO_VAL_FRACTIONAL;
>  	case IIO_CHAN_INFO_OFFSET:
>  		val64 = (((u64)st->vref_neg_mv) << chan->scan_type.realbits);
>  		do_div(val64, st->vref_mv);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux