On 08/19/13 16:15, Pandruvada, Srinivas wrote: > If IIO_VAL_INT_PLUS_MICRO is by default, then this patch is fine. It is, so I'll take that as an Acked-by. Applied to the togreg branch of iio.git Thanks, Jonathan > > -----Original Message----- > From: Peter Meerwald [mailto:pmeerw@xxxxxxxxxx] > Sent: Sunday, August 18, 2013 6:07 AM > To: linux-iio@xxxxxxxxxxxxxxx > Cc: Peter Meerwald; Pandruvada, Srinivas > Subject: [PATCH] iio: Remove unnecessary _write_raw_get_fmt() in several hid-sensor drivers > > IIO_VAL_INT_PLUS_MICRO is the default, no need to return it explicitly > > Signed-off-by: Peter Meerwald <pmeerw@xxxxxxxxxx> > Cc: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxx> > --- > drivers/iio/accel/hid-sensor-accel-3d.c | 8 -------- > drivers/iio/gyro/hid-sensor-gyro-3d.c | 8 -------- > drivers/iio/light/hid-sensor-als.c | 8 -------- > drivers/iio/magnetometer/hid-sensor-magn-3d.c | 8 -------- > 4 files changed, 32 deletions(-) > > diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c > index 68df341..46d22f3 100644 > --- a/drivers/iio/accel/hid-sensor-accel-3d.c > +++ b/drivers/iio/accel/hid-sensor-accel-3d.c > @@ -175,18 +175,10 @@ static int accel_3d_write_raw(struct iio_dev *indio_dev, > return ret; > } > > -static int accel_3d_write_raw_get_fmt(struct iio_dev *indio_dev, > - struct iio_chan_spec const *chan, > - long mask) > -{ > - return IIO_VAL_INT_PLUS_MICRO; > -} > - > static const struct iio_info accel_3d_info = { > .driver_module = THIS_MODULE, > .read_raw = &accel_3d_read_raw, > .write_raw = &accel_3d_write_raw, > - .write_raw_get_fmt = &accel_3d_write_raw_get_fmt, > }; > > /* Function to push data to buffer */ > diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c > index 9cc8aa1..be95179 100644 > --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c > +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c > @@ -175,18 +175,10 @@ static int gyro_3d_write_raw(struct iio_dev *indio_dev, > return ret; > } > > -static int gyro_3d_write_raw_get_fmt(struct iio_dev *indio_dev, > - struct iio_chan_spec const *chan, > - long mask) > -{ > - return IIO_VAL_INT_PLUS_MICRO; > -} > - > static const struct iio_info gyro_3d_info = { > .driver_module = THIS_MODULE, > .read_raw = &gyro_3d_read_raw, > .write_raw = &gyro_3d_write_raw, > - .write_raw_get_fmt = &gyro_3d_write_raw_get_fmt, > }; > > /* Function to push data to buffer */ > diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c > index 84cf004..e59d00c 100644 > --- a/drivers/iio/light/hid-sensor-als.c > +++ b/drivers/iio/light/hid-sensor-als.c > @@ -154,18 +154,10 @@ static int als_write_raw(struct iio_dev *indio_dev, > return ret; > } > > -static int als_write_raw_get_fmt(struct iio_dev *indio_dev, > - struct iio_chan_spec const *chan, > - long mask) > -{ > - return IIO_VAL_INT_PLUS_MICRO; > -} > - > static const struct iio_info als_info = { > .driver_module = THIS_MODULE, > .read_raw = &als_read_raw, > .write_raw = &als_write_raw, > - .write_raw_get_fmt = &als_write_raw_get_fmt, > }; > > /* Function to push data to buffer */ > diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c > index 5a6162d..a98460b 100644 > --- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c > +++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c > @@ -176,18 +176,10 @@ static int magn_3d_write_raw(struct iio_dev *indio_dev, > return ret; > } > > -static int magn_3d_write_raw_get_fmt(struct iio_dev *indio_dev, > - struct iio_chan_spec const *chan, > - long mask) > -{ > - return IIO_VAL_INT_PLUS_MICRO; > -} > - > static const struct iio_info magn_3d_info = { > .driver_module = THIS_MODULE, > .read_raw = &magn_3d_read_raw, > .write_raw = &magn_3d_write_raw, > - .write_raw_get_fmt = &magn_3d_write_raw_get_fmt, > }; > > /* Function to push data to buffer */ > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
