On 08/13/2013 01:22 PM, Oleksandr Kravchenko wrote:
On Tue, Aug 13, 2013 at 1:01 PM, Peter Meerwald <pmeerw@xxxxxxxxxx> wrote:
This patch adds IIO driver for Bosch BMA180 triaxial
acceleration sensor.
http://omapworld.com/BMA180_111_1002839.pdf
the DS is preliminary, more up-to-date version available
comments inline
---
.../devicetree/bindings/iio/accel/bma180.txt | 35 ++
drivers/iio/accel/Kconfig | 12 +
drivers/iio/accel/Makefile | 2 +
drivers/iio/accel/bma180.c | 635 ++++++++++++++++++++
4 files changed, 684 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/accel/bma180.txt
create mode 100644 drivers/iio/accel/bma180.c
diff --git a/Documentation/devicetree/bindings/iio/accel/bma180.txt b/Documentation/devicetree/bindings/iio/accel/bma180.txt
new file mode 100644
index 0000000..e08780b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/accel/bma180.txt
@@ -0,0 +1,35 @@
+* Bosch BMA180 triaxial acceleration sensor
+
+http://omapworld.com/BMA180_111_1002839.pdf
+
+Required properties:
+
+ - compatible : should be "bosch,bma180"
+ - reg : the I2C address of the sensor
+
+Optional properties:
+
+ - interrupt-parent : should be the phandle for the interrupt controller
+
+ - interrupts : interrupt mapping for GPIO IRQ, it should by configured with
+ flags IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING
+
+ - bosch,resolution : ADC resolution. Must be 130, 190, 250, 380, 500,
+ 990 or 1980 mcg/LSB only
what is mcg?
mcg is microgram (http://en.wikipedia.org/wiki/Kilogram#SI_multiples)
How to call it more correctly?
I would be very surprised if g was gram. g is usually acceleration in this
context, 9.81m/s**2
But again same question as before, shouldn't this rather be runtime
configurable? Same for bandwidth.
- Lars
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
