On 08/04/2013 01:55 PM, Jonathan Cameron wrote: > On 07/19/13 14:36, Jacek Anaszewski wrote: >> This patch adds DT support for the lps331ap barometer >> sensor. >> >> Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > This makes sense to me and looks similar to that in existing bindings > hence, > > Applied to the togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git > > Note I am one of those maintainers who has very limited knowledge of device > tree so am basing this decision on the 'it looks like existing mappings' rather > than any deep understanding. The bindings are not OK. [...] >> + - drdy-int-pin : redirect DRDY on pin INT1 (1) or pin INT2 (2) (u8) This is a vendor specific property, so it needs a vendor prefix. Also abbreviations are kind of frowned upon for dt property names. So 'st,data-ready-interrupt-pin' is probably a better name. >> + - interrupt-parent : phandle to the interrupt map subnode >> + - interrupts : interrupt mapping for LPS331AP interrupt sources: >> + 2 sources: 0 - data ready, 1 - threshold event >> + - irq-map : irq sub-node defining interrupt map >> + (all properties listed below are required): >> + - #interrupt-cells : should be 1 >> + - #address-cells : should be 0 >> + - #size-cells : should be 0 >> + - interrupt-map : table of entries consisting of three child elements: >> + - unit_interrupt_specifier - 0 : data ready, 1 : threshold event >> + - interrupt parent phandle >> + - parent unit interrupt specifier consisiting of two elements: >> + - index of the interrupt within the controller [...] -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
