On 07/04/2013 10:08 AM, Lars-Peter Clausen wrote: > On 06/24/2013 07:24 PM, Alexandre Belloni wrote: >> The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable >> gain and sampling rates. >> >> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> > > Reviewed-by: Lars-Peter Clausen <lars@xxxxxxxxxx> > Applied to the togreg branch of iio.git (with a few little tweaks). There was some fuzz that required manual fixing because of another driver merge so please check I didn't foul anything up with this or the other bits below. There were two trivial missing unlocks on error paths in the read_raw function that I've fixed up (Coccinelle found these for me - if you can I would always advise running sparse, coccicheck and ideally smatch before submitting patches). I fixed up the comments because if there is one thing I hate bothering with it is delightful patches that just fix this stuff. Much better to do it now given it took 20 secs ;) > One remark though. Multiline comments should be like > > /* > * foo > * bar > */ > > not > > /* foo > * bar > */ > > But not need to resend the patch just for this > > - Lars > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
