Re: [PATCH] iio: mxs-lradc: Remove useless check in read_raw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Marek,

On 07/02/2013 02:08 AM, Marek Vasut wrote:
The removed check in the read_raw implementation was always true,
therefore remove it.

Signed-off-by: Marek Vasut <marex@xxxxxxx>
Cc: Jonathan Cameron <jic23@xxxxxxxxxx>
Cc: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
---
  drivers/staging/iio/adc/mxs-lradc.c |    7 -------
  1 file changed, 7 deletions(-)

diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index d92c97a..c318eb6 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -234,7 +234,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
  {
  	struct mxs_lradc *lradc = iio_priv(iio_dev);
  	int ret;
-	unsigned long mask;

  	if (m != IIO_CHAN_INFO_RAW)
  		return -EINVAL;
@@ -243,12 +242,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
  	if (chan->channel > LRADC_MAX_TOTAL_CHANS)
  		return -EINVAL;

-	/* Validate the channel if it doesn't intersect with reserved chans. */
-	bitmap_set(&mask, chan->channel, 1);
-	ret = iio_validate_scan_mask_onehot(iio_dev, &mask);
-	if (ret)
-		return -EINVAL;
-
  	/*
  	 * See if there is no buffered operation in progess. If there is, simply
  	 * bail out. This can be improved to support both buffered and raw IO at


By "always true" you mean that it always entered the if and exited with -EINVAL, right?
I just started to look at this driver on my MX28 platform and this check was always returning -EINVAL. With this patch I can now read the channels.
Was this what was happening to you as well?

Thank you,
--
Héctor Palacios

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux