On 06/18/2013 02:08 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
This one looks pretty obvious so I'll take it without waiting
for any other comments.
Applied to togreg branch of iio.git
Thanks,
> ---
> drivers/iio/dac/ad7303.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
> index 85aeef6..d546f50 100644
> --- a/drivers/iio/dac/ad7303.c
> +++ b/drivers/iio/dac/ad7303.c
> @@ -235,8 +235,10 @@ static int ad7303_probe(struct spi_device *spi)
>
> if (ext_ref) {
> st->vref_reg = regulator_get(&spi->dev, "REF");
> - if (IS_ERR(st->vref_reg))
> + if (IS_ERR(st->vref_reg)) {
> + ret = PTR_ERR(st->vref_reg);
> goto err_disable_vdd_reg;
> + }
>
> ret = regulator_enable(st->vref_reg);
> if (ret)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
