Re: iio: frequency: New driver for Analog Devices ADF4350/ADF4351 Wideband Synthesizers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 23, 2013 at 10:23:32AM +0200, Michael Hennerich wrote:
> Thanks for the reminder.
> We actually fixed the typo in the mask some time ago,
> 0x9 should be 0x3, we send a patch shortly.
> 
> 7 or 3 being signed by default shouldn't matter. The whole term
> at the end is just a big mask used to reject some bits being
> set in r2_user_settings.

It's truncated away, yes.  But sign extension from int literals is
an easy thing for the static checkers to spot and it's upsets and
worries them.  Let's fix that as well, I would do it but it's an
awkward thing because I have to wait for your first patch and then
write a patch on top of that...

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux