On 22/05/13 09:19, Lars-Peter Clausen wrote:
On 05/22/2013 10:04 AM, Jonathan Cameron wrote:
On 22/05/13 08:49, Guillaume Ballet wrote:
Hello,
The read_raw operation in iio_info has a signature that takes two
integer as in/out parameters. This lets the driver return values with
micro- or nano-unit precision.
However, the high-level iio_read_channel_raw and
iio_read_channel_processed
Do we even have an iio_read_channel_processed? I think you are referring
to the in kernel consumer interface. In iio/consumer.h we have an
iio_read_channel_raw but unless I am going mad no iio_read_channel_processed
(as of yet).
https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/tree/include/linux/iio/consumer.h?h=togreg
(is the latest development tree).
Which tree are you looking at?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/iio/consumer.h#n145
Weird. I'm clearly going to be doing some checking of why that isn't in
my togreg branch (at least on kernel.org). I did have some strange
problems pushing the other day. I wonder if that branch has gotten into
a weird state.
functions' signature only has one integer
in/out parameter. That makes sense in the context of _raw because the
value isn't yet processed.
However, as the scale is a number encoded over two ints, the
_processed value should also span two ints. Is there a reason why it's
still only one int?
No it certainly should not be one int for exactly the reasons you have stated.
I'm not to sure about that. I'd rather add a scale parameter to the
iio_read_channel_processed, just in the same way the
convert_raw_to_processed function takes a scale parameter.
That may be tricky to do given we often have nasty non linear functions
that are the reason we are using processed in the first place. Hmm.
Not sure which way works better.
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
