Re: [PATCH 2/2] iio: ak8975: Implement data ready interrupt handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/06/2013 06:49 PM, Jonathan Cameron wrote:
On 04/16/2013 03:37 PM, Jacek Anaszewski wrote:
Implement "data ready" interrupt handling in addition to the
two existing read modes - DRDY GPIO polling and ST1 register
DRDY bit polling.

Signed-off-by: Jacek Anaszewski<j.anaszewski@xxxxxxxxxxx>
Signed-off-by: Kyungmin Park<kyungmin.park@xxxxxxxxxxx>
Cc: Andrew Chew<achew@xxxxxxxxxx>

Allowing either the gpio or the interrupt is a little ususual, but
I suppose does avoid having to change existing users to gain interrupt
support (if their gpio subsystem happens to support interrupts).

Thanks for the review. I am going to send new series promptly.

Regarding the gpio issue - I can imagine the situation when there is no available interrupt pin at the CPU, as they were all connected to the other devices, there are some free general purpose pins though. It is always better to have a possibility to periodically read the state of such a pin, instead of performing cycling I2C transmission to check the status of DRDY bit in the ST1 register, which is a fallback in the driver.

Thanks,
Jacek Anaszewski

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux