On Sat, Apr 20, 2013 at 07:14:02PM +0200, Lars-Peter Clausen wrote: > Hi, > > Looks much better than v1 :) Only a few minor things left > > > On 04/18/2013 12:45 PM, Denis Darwish wrote: > > From: Denis Darwish <darwish.d.d@xxxxxxxxx> > > > > This patch adds basic support for Freescale i.MX25 ADC in the IIO Subsystem. > > > > Signed-off-by: Denis Darwish <darwish.d.d@xxxxxxxxx> > > --- > > I want to thank Lars-Peter Clausen for a detailed review. > > > > Functionality tested with linux 3.8.0 and linux-next. > > IIO_BUFFER and IIO_TRIGGER unsupported > > Changes since v1: > > + end of conversion IRQ support > > * cleanup debug info messages, vars etc. > > * all definitions put into c file > > * iio_chan_spec statically initialized > > * get resources in modern way (clk, iomem etc) > > > > arch/arm/mach-imx/clk-imx25.c | 2 +- > > arch/arm/mach-imx/devices/Kconfig | 4 + > > arch/arm/mach-imx/devices/Makefile | 1 + > > arch/arm/mach-imx/devices/devices-common.h | 2 + > > arch/arm/mach-imx/devices/platform-imx25-adc.c | 27 + I don't know Shawns take on this, but I think we are beyond the point where we add new platform devices. New boards should use devicetree which is sufficiently well supported on i.MX25. > > arch/arm/mach-imx/mx25.h | 2 + > > drivers/iio/adc/Kconfig | 7 + > > drivers/iio/adc/Makefile | 1 + > > drivers/iio/adc/imx25_adc.c | 639 ++++++++++++++++++++++++ > > This should be split into two patch, the first patch adding the IIO driver, > the second one registering the platform device. Also make sure to put the > imx maintainers on Cc. Yes, at least the ARM Linux kernel Mailing List should be on Cc. > > + if (!ret) > > + return -EBUSY; > > + > > + INIT_COMPLETION(st->completion); > > + > > + imx_adc_set_chanel(st, chan->channel); Chanel is a fashion and perfume vendor. I think you mean channel. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
