On 02/03/2013 05:18 PM, Guenter Roeck wrote: > On Sun, Feb 03, 2013 at 12:10:32PM +0000, Jonathan Cameron wrote: >> On 02/03/2013 12:59 AM, Guenter Roeck wrote: >>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> >> Applied to togreg branch of iio.git. >> >> Note I'll probably rebase the togreg branch if / when Greg has pulled >> last pull request (sent a few mins ago) so as to get a directly >> applied fix for this driver. >> > No problem. > > There is some dead code in the max1363 driver. > > drivers/iio/adc/max1363.c:1492:12: warning: 'max1363_register_buffered_funcs_and_init' defined but not used [-Wunused-function] > drivers/iio/adc/max1363.c:1527:13: warning: 'max1363_buffer_cleanup' defined but not used [-Wunused-function] > > I thought I had seen a note on the iio mailing list that you wanted to submit a patch for it, Went out yesterday as [PATCH] iio:max1363 remove some functions left after merge > but I didn't see it yet. Or maybe my memory is wrong, or you were talking about > something else. It's gone to Greg who added it staging-next yesterday (rather than throw the iio tree). I actually intended to get his Ack on it (as the merge that caused it was I think his), but he applied it directly. Anyhow, that's the reason staging-next with that patch will differ from iio.git and hence why I'll rebase once the current pull request is dealt with. > > Want me to submit a patch (assuming the fix is simply to remove the above functions) ? All sorted if via an indirect route. > > Thanks, > Guenter > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
