Hi Lars-Peter, >> diff --git a/drivers/iio/accel/st_accel_buffer.c b/drivers/iio/accel/st_accel_buffer.c > > This file looks pretty much the same for all drivers, any reason why it > can't be shared? >> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c > > Here again the function looks exactly the same in all three drivers and > could probably be moved to the common library. You are right, but the idea is that: one common library for all common functions, but leave the code clear ( easy to read). In the future I want to patch the current driver to support other features. What do you think about? Denis-- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html