On 12/18/2012 03:33 AM, Axel Lin wrote: > regulator_get_voltage() may return negative error code. > Add error checking to avoid setting error code to voltage_uv. > > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx> added to fixes-togreg branch of iio.git > --- > Sorry. Just found I made the same mistake again. > Here is v2, should check if ret is negative value. > drivers/iio/dac/ad5446.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c > index 3310cbb..607378f 100644 > --- a/drivers/iio/dac/ad5446.c > +++ b/drivers/iio/dac/ad5446.c > @@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name, > if (ret) > goto error_put_reg; > > - voltage_uv = regulator_get_voltage(reg); > + ret = regulator_get_voltage(reg); > + if (ret < 0) > + goto error_disable_reg; > + > + voltage_uv = ret; > } > > indio_dev = iio_device_alloc(sizeof(*st)); > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
