On 12/12/2012 11:14 AM, Alexander Holler wrote: > Am 12.12.2012 10:51, schrieb Lars-Peter Clausen: > >> Looks good, but as I wrote during the last review the __devinits need to go. >> A few other suggerstions online > > Oh, have forgotten it. Ok, will make a v4, changing the other few things too. > >>> + case HID_USAGE_SENSOR_TIME_MONTH: >>> + time_buf->tm_mon = --*(u8 *)raw_data; > > Time sensors are sending the month in the range 1-12, not 0-11. > Ah, sorry, I guess hadn't had enough coffee yet, I read this as -(-(*(u8 *)raw_data))) and was a bit confused... -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
