On 11/27/2012 06:40 PM, Lars-Peter Clausen wrote:
> On 11/27/2012 08:24 AM, Dan Carpenter wrote:
>> It's slightly cleaner to use kstrtouint() because we pass unsigned ints
>> to adis16136_set_freq(). On 64 bit systems, if the user passed LONG_MIN
>> then it we would get past the test against zero but crash in
>> adis16136_set_freq() because we truncate the high bits away.
>>
>>
>
> Thanks,
>
> Acked-By: Lars-Peter Clausen <lars@xxxxxxxxxx>
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Added to togreg branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
>>
>> diff --git a/drivers/iio/gyro/adis16136.c b/drivers/iio/gyro/adis16136.c
>> index 05486df..b4ee339 100644
>> --- a/drivers/iio/gyro/adis16136.c
>> +++ b/drivers/iio/gyro/adis16136.c
>> @@ -203,10 +203,10 @@ static ssize_t adis16136_write_frequency(struct device *dev,
>> {
>> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>> struct adis16136 *adis16136 = iio_priv(indio_dev);
>> - long val;
>> + unsigned int val;
>> int ret;
>>
>> - ret = kstrtol(buf, 10, &val);
>> + ret = kstrtouint(buf, 10, &val);
>> if (ret)
>> return ret;
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
