Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>On 10/08/2012 09:50 PM, Pavel Machek wrote:
>>
>>>> drivers/iio/accel/STMicroelectronics_accelerometers_iio_i2c.c
>>>> create mode 100644
>>>> drivers/iio/accel/STMicroelectronics_accelerometers_iio_spi.c
>>>> create mode 100644
>>>> drivers/iio/accel/STMicroelectronics_accelerometers_iio_trigger.c
>>>
>>> the file names are a bit excessive in my opinion. How about
>>> st_accel_{buffer,core,i2c,...}.c?
>>
>> drivers/iio/accel/st/iio_spi.c ?
>
>Maybe. I'd still vote for st_accel though, since I think it is most
>descriptive. Since trigger and buffer should go down to a few lines it
>probably
>makes sense to put their content into the core file and I don't think
>we need a
>extra directory for the driver then.
>
Agreed. Either is an improvement but Lars' is more in keeping with other drivers. Doesn't need its own dir. Whilst this one is large it isn't exceptionally so.
>- Lars
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
