Re: [PATCH] iio: add driver for si114x ambient light / proximity sensors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/08/2012 06:53 PM, Jonathan Cameron wrote:
> On 09/07/2012 12:36 AM, Peter Meerwald wrote:
[...]
>> +
>> +struct si114x_platform_data {
>> +	bool use_irq;
> It's a bit nasty, but you could drop this and rely on client->irq = NO_IRQ
> in the platform data.   If only the no irq = 0 had always been enforced...

NO_IRQ constant is deprecated anyway, and 0 is the new "no irq". So just
checking if client->irq is 0 should be fine to find out whether to use IRQs or not.

>> +	int irq_flags;
> Which flags actually make sense here?  Just curious really.
>> +};
>> +
>> +#endif /* SI114X_H */
>> +
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux