On 09/07/2012 10:12 AM, Lars-Peter Clausen wrote: > On 09/06/2012 11:20 PM, Jonathan Cameron wrote: >> Consistently use iio_push_to_buffer instead of manually calling the buffers >> store_to callback. >> >> These crossed with Lars-Peter's patch set doing every other case. > Actually I only did this for drivers/staging/iio, the at91_adc driver in > drivers/iio still uses the store_to callback as well, might make sense to > convert it as well in this patch. Your second patch did cover the dropping of the timestamp so I'm happy to let this one driver go briefly in the interests of not waiting for an ack before pushing these out. Will send out a suitable patch for that one later. > >> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxxx> >> --- >> drivers/iio/accel/hid-sensor-accel-3d.c | 2 +- >> drivers/iio/gyro/hid-sensor-gyro-3d.c | 2 +- >> drivers/iio/light/hid-sensor-als.c | 2 +- >> drivers/iio/magnetometer/hid-sensor-magn-3d.c | 2 +- >> 4 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c >> index 33aa97c..c593eb23 100644 >> --- a/drivers/iio/accel/hid-sensor-accel-3d.c >> +++ b/drivers/iio/accel/hid-sensor-accel-3d.c >> @@ -212,7 +212,7 @@ static void hid_sensor_push_data(struct iio_dev *indio_dev, u8 *data, int len) >> datum_sz); >> return; >> } >> - buffer->access->store_to(buffer, (u8 *)data, timestamp); >> + iio_push_to_buffer(buffer, (u8 *)data, timestamp); >> } >> >> /* Callback handler to send event after all samples are received and captured */ >> diff --git a/drivers/iio/gyro/hid-sensor-gyro-3d.c b/drivers/iio/gyro/hid-sensor-gyro-3d.c >> index 50ec09b..94a4740 100644 >> --- a/drivers/iio/gyro/hid-sensor-gyro-3d.c >> +++ b/drivers/iio/gyro/hid-sensor-gyro-3d.c >> @@ -212,7 +212,7 @@ static void hid_sensor_push_data(struct iio_dev *indio_dev, u8 *data, int len) >> datum_sz); >> return; >> } >> - buffer->access->store_to(buffer, (u8 *)data, timestamp); >> + iio_push_to_buffer(buffer, (u8 *)data, timestamp); >> } >> >> /* Callback handler to send event after all samples are received and captured */ >> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c >> index 2cff7d5..b3c8e91 100644 >> --- a/drivers/iio/light/hid-sensor-als.c >> +++ b/drivers/iio/light/hid-sensor-als.c >> @@ -191,7 +191,7 @@ static void hid_sensor_push_data(struct iio_dev *indio_dev, u8 *data, int len) >> datum_sz); >> return; >> } >> - buffer->access->store_to(buffer, (u8 *)data, timestamp); >> + iio_push_to_buffer(buffer, (u8 *)data, timestamp); >> } >> >> /* Callback handler to send event after all samples are received and captured */ >> diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c b/drivers/iio/magnetometer/hid-sensor-magn-3d.c >> index 07591f4..397704e 100644 >> --- a/drivers/iio/magnetometer/hid-sensor-magn-3d.c >> +++ b/drivers/iio/magnetometer/hid-sensor-magn-3d.c >> @@ -213,7 +213,7 @@ static void hid_sensor_push_data(struct iio_dev *indio_dev, u8 *data, int len) >> datum_sz); >> return; >> } >> - buffer->access->store_to(buffer, (u8 *)data, timestamp); >> + iio_push_to_buffer(buffer, (u8 *)data, timestamp); >> } >> >> /* Callback handler to send event after all samples are received and captured */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
