Re: [PATCH 22/22] staging:iio:adc: Add AD7791 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/11/2012 10:41 AM, Peter Meerwald wrote:
> 
> two minor comments below
>

Thanks.

>>[...]
>> +static const char * const ad7791_sample_freq_avail[] = {
>> +	[AD7791_FILTER_RATE_120] = "120",
>> +	[AD7791_FILTER_RATE_100] = "100",
>> +	[AD7791_FILTER_RATE_33_3] = "33.3",
>> +	[AD7791_FILTER_RATE_20] = "20",
>> +	[AD7791_FILTER_RATE_16_6] = "16.6",
>> +	[AD7791_FILTER_RATE_16_7] = "16.7",
> 
> just curious; why is this not in strictly decreasing order?
> IIO_CONST_ATTR_SAMP_FREQ_AVAIL is...

It doesn't really matter, but to keep the indices in order.
AD7791_FILTER_RATE_16_6 is 0x4 and AD7791_FILTER_RATE_16_7 is 0x5.


> 
>> +	[AD7791_FILTER_RATE_13_3] = "13.3",
>> +	[AD7791_FILTER_RATE_9_5] = "9.5",
>> +};
>> +

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux