Re: [PATCH] iio: staging: ad7298_ring: Fix maybe-uninitialized warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Well - calling a function to initialize a variable which isn't being used
> anywhere doesn't make more sense.
 
> IMHO a more adequate fix would be to remove the timestamp argument from
> store_to(),
> since it isn't used anywhere.

so
indio_dev->buffer->access->store_to(ring, (u8 *)buf, time_ns);
should become
iio_push_to_buffer(buffer, (u8 *)data->buffer, time_ns);
and you suggest to drop the last argument?

I wasn't aware that timestamp is not used; at least iio_store_to_kfifo() 
and iio_store_to_sw_ring() just ignore it

p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux