On 07/03/2012 11:42 AM, Zhang, Sonic wrote: > Acked-by: Sonic Zhang <sonic.zhang@xxxxxxxxxx> > >> -----Original Message----- >> From: Sascha Hauer [mailto:s.hauer@xxxxxxxxxxxxxx] >> Sent: Tuesday, July 03, 2012 5:21 PM >> To: linux-iio@xxxxxxxxxxxxxxx >> Cc: Jonathan Cameron; Zhang, Sonic; Sascha Hauer >> Subject: [PATCH 3/3] staging iio adt7410: make 16bit mode default >> >> In 13bit mode the lower three bits of the adc value contain >> flags. The driver does not use these flags at all, so make 16bit >> mode the default. >> >> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> merged (for next version rather than fixes as whilst a reasonable change, it's not a fix). Anyhow, please do note that the intent is to move this driver out to hwmon. It's a long way from abi compliant for iio. I just mention this to avoid you wasting time pulling it nearer to the abi (if you were thinking of doing so of course!) >> --- >> drivers/staging/iio/adc/adt7410.c | 24 +++++++++++++----------- >> 1 file changed, 13 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/staging/iio/adc/adt7410.c b/drivers/staging/iio/adc/adt7410.c >> index f9188e5..f8dd567 100644 >> --- a/drivers/staging/iio/adc/adt7410.c >> +++ b/drivers/staging/iio/adc/adt7410.c >> @@ -756,13 +756,15 @@ static int __devinit adt7410_probe(struct i2c_client >> *client, >> goto error_unreg_ct_irq; >> } >> >> - if (client->irq && adt7410_platform_data[0]) { >> + ret = adt7410_i2c_read_byte(chip, ADT7410_CONFIG, &chip->config); >> + if (ret) { >> + ret = -EIO; >> + goto error_unreg_int_irq; >> + } >> >> - ret = adt7410_i2c_read_byte(chip, ADT7410_CONFIG, &chip- >>> config); >> - if (ret) { >> - ret = -EIO; >> - goto error_unreg_int_irq; >> - } >> + chip->config |= ADT7410_RESOLUTION; >> + >> + if (client->irq && adt7410_platform_data[0]) { >> >> /* set irq polarity low level */ >> chip->config &= ~ADT7410_CT_POLARITY; >> @@ -771,12 +773,12 @@ static int __devinit adt7410_probe(struct i2c_client >> *client, >> chip->config |= ADT7410_INT_POLARITY; >> else >> chip->config &= ~ADT7410_INT_POLARITY; >> + } >> >> - ret = adt7410_i2c_write_byte(chip, ADT7410_CONFIG, chip- >>> config); >> - if (ret) { >> - ret = -EIO; >> - goto error_unreg_int_irq; >> - } >> + ret = adt7410_i2c_write_byte(chip, ADT7410_CONFIG, chip->config); >> + if (ret) { >> + ret = -EIO; >> + goto error_unreg_int_irq; >> } >> ret = iio_device_register(indio_dev); >> if (ret) >> -- >> 1.7.10 >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
