Re: [PATCH] iio:adc:at91: Relase mutex on error path in at91_adc_read_raw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/25/2012 04:00 PM, Maxime Ripard wrote:
> Hi Lars,
> 
> You can add my
> Acked-By: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> 
> Thanks,
> Maxime
> 
> Le 25/06/2012 15:43, Lars-Peter Clausen a écrit :
>> This issue was reported by the mini_lock.cocci coccinelle semantic patch.
>>
>> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
>> ---
>>  drivers/iio/adc/at91_adc.c |    6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
>> index 6a08469..f61780a 100644
>> --- a/drivers/iio/adc/at91_adc.c
>> +++ b/drivers/iio/adc/at91_adc.c
>> @@ -349,9 +349,11 @@ static int at91_adc_read_raw(struct iio_dev *idev,
>>  						       st->done,
>>  						       msecs_to_jiffies(1000));
>>  		if (ret == 0)
>> -			return -ETIMEDOUT;
>> -		else if (ret < 0)
>> +			ret = -ETIMEDOUT;
>> +		if (ret < 0) {
>> +			mutex_unlock(&st->lock);
>>  			return ret;
>> +		}
>>  
>>  		*val = st->last_value;
>>  
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux