Hello Greg, > On Mon, Jun 18, 2012 at 08:33:00PM +0200, Peter Meerwald wrote: > > minimal driver, no IR current control and proximity/event handling > > Care to fix up the basic checkpatch.pl warnings and errors it produces? it gives me 4 warning, but no errors: WARNING: line over 80 characters +#define VCNL4000_PS_MEAS_FREQ 0x89 /* Proximity measurement signal frequency */ WARNING: line over 80 characters + ret = i2c_smbus_write_byte_data(data->client, VCNL4000_COMMAND, req_mask); ok WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(1); this is indeed interesting; a sensor measurement/conversion can take up to 100 ms and the data ready loop with msleep(1) and 20 retries is depending on the behaviour that msleep(1) actually takes >= 20 ms checkpatch is happy with msleep(20) I wonder how often this warning is worked around with something like msleep(SOME_DELAY) with #define SOME_DELAY 1... WARNING: quoted string split across lines #241: FILE: drivers/iio/light/vcnl4000.c:172: + dev_info(&client->dev, "VCNL4000 Ambient light/proximity sensor, " + "Prod %02x, Rev: %02x\n", ret >> 4, ret & 0xf); ok, I thought a split line would be more readable; checkpatch is happy with the long line thanks, p. -- Peter Meerwald +43-664-2444418 (mobile) -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
