On 06/11/2012 11:02 AM, Shubhrajyoti Datta wrote:
Hi Michael, On Mon, Jun 11, 2012 at 1:21 PM,<michael.hennerich@xxxxxxxxxx> wrote:From: Michael Hennerich<michael.hennerich@xxxxxxxxxx> drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map() warn: value 2 can't fit into 1 'out' Signed-off-by: Michael Hennerich<michael.hennerich@xxxxxxxxxx> Reported-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx> --- drivers/iio/frequency/ad9523.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 7272924..43f47d9 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -361,7 +361,7 @@ static int ad9523_io_update(struct iio_dev *indio_dev) } static int ad9523_vco_out_map(struct iio_dev *indio_dev, - unsigned ch, bool out) + unsigned ch, unsigned out)Unsigned defaults to unsigned int right shouldnt it be a char? Or am I missing something.
Hi Shubhrajyoti, can you explain why this matters? If you take a closer look at the disassembly - you will notice that 'unsigned int' will generate nicer code. -- Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
