Re: [PATCH 2/9] iio:adc:at91: Use new triggered buffer setup helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/8/2012 8:57 AM, Lars-Peter Clausen wrote:
On 06/07/2012 10:02 PM, Jonathan Cameron wrote:
On 06/06/2012 12:55 PM, Lars-Peter Clausen wrote:
Use the new triggered buffer setup helper function to allocate and register
buffer and pollfunc.

Other than dropping IIO_TRIGGER select this is fine.
Signed-off-by: Lars-Peter Clausen<lars@xxxxxxxxxx>
Cc: Maxime Ripard<maxime.ripard@xxxxxxxxxxxxxxxxxx>
Acked-by: Jonathan Cameron<jic23@xxxxxxxxxx>
---
  drivers/iio/adc/Kconfig    |    2 +-
  drivers/iio/adc/at91_adc.c |   49 +++-----------------------------------------
  2 files changed, 4 insertions(+), 47 deletions(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 9a0df81..bbd2291 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -7,7 +7,7 @@ config AT91_ADC
  	tristate "Atmel AT91 ADC"
  	depends on ARCH_AT91
  	select IIO_BUFFER
-	select IIO_KFIFO_BUF
+	select IIO_TRIGGERED_BUFFER
  	select IIO_TRIGGER
given IIO_TRIGGERED_BUFFER selects IIO_TRIGGER, drop that as well.

The reasoning for keeping it was, that the driver registers it's own trigger
and as such has a direct dependency on the trigger code. Whereas the kfifo
dependency is now implicit. But I can remove the 'select IIO_TRIGGER' if you
prefer it.
I'd argue that your TRIGGERED_BUFFER encapsulates it anyway in a fairly
obvious fashion.  Hence yes, I'd prefer it is removed.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux