Re: [PATCH] iio: add mcp4725 I2C DAC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/8/2012 8:12 AM, Peter Meerwald wrote:
Hello Jonathan,

from reading the code. Anyhow few things came up via sparse and and
my arm toolchain... (not sure which version off the top of my head)..

   CHECK   drivers/iio/dac/mcp4725.c
drivers/iio/dac/mcp4725.c:45:53: warning: incorrect type in argument 2
(different base types)
drivers/iio/dac/mcp4725.c:45:53:    expected char const *buf
drivers/iio/dac/mcp4725.c:45:53:    got unsigned char [usertype] (
*<noident>  )[2]
drivers/iio/dac/mcp4725.c:58:53: warning: incorrect type in argument 2
(different base types)
drivers/iio/dac/mcp4725.c:58:53:    expected char const *buf
drivers/iio/dac/mcp4725.c:58:53:    got unsigned char [usertype] (
*<noident>  )[2]
   CC [M]  drivers/iio/dac/mcp4725.o

I did not know about sparse

compiling out-of-tree with my toolchain did not yield above warnings,
sorry for the extra review cycle
That's quite all right!  I've done plenty of similar things myself
and had others poitn them out.

regards, p.


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux