On 05/12/2012 03:33 PM, Greg Kroah-Hartman wrote: > On Sat, May 12, 2012 at 04:24:22PM +0200, Lars-Peter Clausen wrote: >> On 05/12/2012 04:18 PM, Greg Kroah-Hartman wrote: >>> On Fri, May 11, 2012 at 03:13:13PM +0200, Lars-Peter Clausen wrote: >>>> This function is currently unused and we do not have a matching iio_device_get() >>>> function either, so just remove it. >>>> >>>> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx> >>>> Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx> >>> >>> No, I see a number of places it should be used. Don't do "raw" >>> put_device() calls, every one of them could be making this call instead, >>> right? >> >> Hm, right in the new inkern code there are some put_device calls on >> indio_dev.dev, I missed those, sorry. But we should really add a matching >> iio_device_get() as well. > > I agree, and then fix up the inkern.c calls to call that as well :) > > thanks, > > greg k-h Got to love code evolution and the mess it can leave. Thanks for picking up on this Greg. I'd completely forgotten those were there when I reviewed it.. Agreed that we want a pair of wrappers and assuming Lars-Peter will add them if I don't hear anything else :) Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
